certbot renewal name collision #12

An occurrence was observed of a "name collision" per https://eff-certbot.readthedocs.io/en/stable/using.html#where-are-my-certificates:
data/certbot/conf/live and data/certbot/conf/archive directory contained woodbine.nyc directory with old certificate/key, and woodbine.nyc-0001 directory with new certificate/key. This was after running nginx/certbot-renew; so the certificate was renewed but the web server was still using the old one. Fix for now was to manually replace the woodbine.nyc directory in live with the woodbine.nyc-0001 one, and then restart the nginx container. This should instead be fixed such that the certificate renewal updates the woodbine.nyc directories without needing additional renaming.

occurred again today.
temp fix:

ln -frs data/certbot/conf/archive/woodbine.nyc-0002/fullchain1.pem data/certbot/conf/live/woodbine.nyc/fullchain.pem
ln -frs data/certbot/conf/archive/woodbine.nyc-0002/privkey1.pem data/certbot/conf/live/woodbine.nyc/privkey.pem
(cd nginx; docker-compose exec nginx nginx -s reload)

fixed

--- a/nginx/certbot-renew
+++ b/nginx/certbot-renew
@@ -21,7 +21,7 @@ fi
 mkdir -p ../data/certbot/conf/archive/old
-mv ../data/certbot/conf/archive/* old
+mv ../data/certbot/conf/archive/"${DOMAIN_NAME}"* ../data/certbot/conf/archive/old/

renewal done today manually

https://basement.woodbine.nyc/ssl-management
edited script to fix execution via symlink:

-DIRNAME="$(dirname $0)"
+DIRNAME="$(dirname $(realpath "$0"))"
 cd "$DIRNAME"