From 6d2fe6308a26caccae11d8ea383fb7a1c3e8517c Mon Sep 17 00:00:00 2001 From: Sameer Puri Date: Tue, 8 Jun 2021 18:52:06 -0400 Subject: [PATCH] remove warning about skewx + skewy, they are correct as far as euclid goes --- src/converter.rs | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/converter.rs b/src/converter.rs index 830b85f..1c8fe30 100644 --- a/src/converter.rs +++ b/src/converter.rs @@ -294,14 +294,10 @@ fn svg_transform_into_euclid_transform(svg_transform: TransformListToken) -> Tra Translate { tx, ty } => Transform2D::translation(tx, ty), Scale { sx, sy } => Transform2D::scale(sx, sy), Rotate { angle } => Transform2D::rotation(Angle::degrees(angle)), - SkewX { angle } => { - warn!("Skew X might not be implemented correctly, please check the GCode output."); - Transform3D::skew(Angle::degrees(angle), Angle::degrees(0f64)).to_2d() - } - SkewY { angle } => { - warn!("Skew Y might not be implemented correctly, please check the GCode output."); - Transform3D::skew(Angle::degrees(0f64), Angle::degrees(angle)).to_2d() - } + // https://drafts.csswg.org/css-transforms/#SkewXDefined + SkewX { angle } => Transform3D::skew(Angle::degrees(angle), Angle::zero()).to_2d(), + // https://drafts.csswg.org/css-transforms/#SkewYDefined + SkewY { angle } => Transform3D::skew(Angle::zero(), Angle::degrees(angle)).to_2d(), } }